Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cpu and traffic into performance overview #19676

Merged
merged 12 commits into from
Jan 26, 2025
Merged

Add cpu and traffic into performance overview #19676

merged 12 commits into from
Jan 26, 2025

Conversation

qiancai
Copy link
Collaborator

@qiancai qiancai commented Jan 23, 2025

fix #18697

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@qiancai qiancai added needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. ok-to-test Indicates a PR is ready to be tested. translation/from-docs This PR is translated from a PR in pingcap/docs. labels Jan 23, 2025
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 23, 2025
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 23, 2025
@qiancai
Copy link
Collaborator Author

qiancai commented Jan 23, 2025

/cc @dbsid

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 23, 2025

@qiancai: GitHub didn't allow me to request PR reviews from the following users: dbsid.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @dbsid

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@qiancai qiancai added needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. labels Jan 23, 2025
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 23, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 23, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-23 07:54:15.55396475 +0000 UTC m=+340182.884884149: ☑️ agreed by hfxsd.

qiancai and others added 2 commits January 23, 2025 16:01
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 24, 2025

@dbsid: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@qiancai
Copy link
Collaborator Author

qiancai commented Jan 26, 2025

/approve

@qiancai qiancai added the lgtm label Jan 26, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 26, 2025
@ti-chi-bot ti-chi-bot bot merged commit 1ae17b9 into pingcap:master Jan 26, 2025
7 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.3: #19688.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 26, 2025
Merged
18 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #19689.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 26, 2025
Merged
18 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.4: #19690.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 26, 2025
Merged
18 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Jan 26, 2025
@ti-chi-bot
Add cpu and traffic into performance overview (#19676) (#19689)
511c124
ti-chi-bot bot pushed a commit that referenced this pull request Jan 26, 2025
@ti-chi-bot
Add cpu and traffic into performance overview (#19676) (#19690)
8b4b13d
ti-chi-bot bot pushed a commit that referenced this pull request Jan 26, 2025
@ti-chi-bot
Add cpu and traffic into performance overview (#19676) (#19688)
f6644a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfxsd hfxsd hfxsd approved these changes

@dbsid dbsid dbsid approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. ok-to-test Indicates a PR is ready to be tested. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/from-docs This PR is translated from a PR in pingcap/docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qiancai @ti-chi-bot @dbsid @hfxsd